status/bluetooth: Disconnect device signals on destroy

Devices may outlive the corresponding menu item, for example on
shutdown. Make sure that signals are disconnected correctly in
that case to avoid warnings.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8223
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3669>

diff --git a/js/ui/status/bluetooth.js b/js/ui/status/bluetooth.js
index 794c08cbe89fddaf6fdc05c8788832cdd7edeace..90e7e9f4be8483eae1bee2391c6e2c3311c4d8a1 100644 (file)
--- a/js/ui/status/bluetooth.js
+++ b/js/ui/status/bluetooth.js
@@ -248,8 +248,10 @@ class BluetoothDeviceItem extends PopupMenu.PopupBaseMenuItem {
 
         this.connect('destroy', () => (this._spinner = null));
         this.connect('activate', () => this._toggleConnected().catch(logError));
-        this._device.connect('notify::alias', () => this._updateAccessibleName());
-        this._device.connect('notify::connected', () => this._updateAccessibleName());
+        this._device.connectObject(
+            'notify::alias', () => this._updateAccessibleName(),
+            'notify::connected', () => this._updateAccessibleName(),
+            this);
         this._updateAccessibleName();
     }